Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gateway-like urls pinning support #17505

Merged
merged 4 commits into from
Mar 10, 2023
Merged

Gateway-like urls pinning support #17505

merged 4 commits into from
Mar 10, 2023

Conversation

cypt4
Copy link
Collaborator

@cypt4 cypt4 commented Mar 6, 2023 •
edited
Loading

  1. Allow pinning urls like https://ipfs.io/ipfs/CID by tranlsating them to ipfs://scheme.
  2. In the IPFS banner only pinned NFTs count is used. (This is needed because wrong counter may be shown otherwise)

Resolves brave/brave-browser#28169
Resolves brave/brave-browser#28928

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Test NFT pinning for some NFT that contains gateway-like url for metadata and image. Like this one : 0x9401518f4ebba857baa879d9f76e1cc8b31ed197

@cypt4 cypt4 requested review from a team as code owners March 6, 2023 22:58
@github-actions github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet feature/web3/wallet/core labels Mar 6, 2023
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@cypt4 cypt4 changed the title Brave 28169 Gateway-like urls pinning support Mar 7, 2023
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

muliswilliam
muliswilliam approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@muliswilliam muliswilliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yrliou
yrliou approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@yrliou yrliou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wallet-core++

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@cypt4 cypt4 merged commit 3f0fbad into master Mar 10, 2023
@cypt4 cypt4 deleted the brave_28169 branch March 10, 2023 13:00
@github-actions github-actions bot added this to the 1.51.x - Nightly milestone Mar 10, 2023
cypt4 added a commit that referenced this pull request Mar 16, 2023
@cypt4
Gateway-like urls pinning support (#17505)
5baa09a 
* Gateway-like urls pinning support
Allow pinning of gateway-like urls
Resolves brave/brave-browser#28169
Show only pinned NFTs count in the IPFS banner
Resolves brave/brave-browser#28928
@cypt4 cypt4 mentioned this pull request Mar 16, 2023
Closed
7 tasks
@srirambv srirambv mentioned this pull request Apr 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrliou yrliou yrliou approved these changes

@muliswilliam muliswilliam muliswilliam approved these changes

@supermassive supermassive Awaiting requested review from supermassive

Assignees

@cypt4 cypt4

Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build feature/web3/wallet/core feature/web3/wallet
Projects
None yet
Milestone
1.51.x - Release
Development

Successfully merging this pull request may close these issues.

Pinned NFTs counter remake Allow pinning gateway-like urls
4 participants
@cypt4 @brave-builds @yrliou @muliswilliam